Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export 406 and rename 413 #448

Merged
merged 2 commits into from
Nov 7, 2020
Merged

fix: export 406 and rename 413 #448

merged 2 commits into from
Nov 7, 2020

Conversation

LEI
Copy link
Contributor

@LEI LEI commented Nov 7, 2020

  • Add missing external export "NotAcceptable"
  • Fix typos in "RequestEntityTooLarge" (breaking change)

For backward compatibility, maybe this line can do the trick, as long as instanceof is used to check the error type:

  RequestEntityToLarge: RequestEntityTooLarge,

cdimascio
cdimascio approved these changes Nov 7, 2020
View reviewed changes
Copy link
Owner

@cdimascio cdimascio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @LEI.
I'm going to commit as is, despite the breaking change due to the typo.

@cdimascio cdimascio merged commit 0f48f1f into cdimascio:master Nov 7, 2020
@cdimascio
Copy link
Owner

@all-contributors add @LEI for code and test

@allcontributors allcontributors bot mentioned this pull request Nov 7, 2020
Merged
@allcontributors
Copy link
Contributor

@cdimascio

I've put up a pull request to add @LEI! 🎉

@LEI LEI deleted the fix-406-413 branch November 7, 2020 21:38
ex1st pushed a commit to ex1st/express-openapi-validator that referenced this pull request Dec 9, 2020
@ex1st
fix: export 406 and rename 413 (cdimascio#448)
127f7d6 
* Export NotAcceptable error type

* Rename RequestEntityTooLarge error type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdimascio cdimascio cdimascio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LEI @cdimascio